> On Jan. 15, 2015, 6:01 p.m., Jie Yu wrote: > > src/common/resources.cpp, lines 432-433 > > <https://reviews.apache.org/r/29911/diff/1/?file=822240#file822240line432> > > > > This fits in one line?
It does indeed. Fixed. > On Jan. 15, 2015, 6:01 p.m., Jie Yu wrote: > > src/common/resources.cpp, line 433 > > <https://reviews.apache.org/r/29911/diff/1/?file=822240#file822240line433> > > > > Can you use ```_resources``` here? Yep, updated `const google::protobuf::RepeatedPtrField<Resource>&` version as well. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29911/#review68275 ----------------------------------------------------------- On Jan. 15, 2015, 6:14 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29911/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 6:14 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and > Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Added Resources(const std::vector<Resource>&). Used in > https://reviews.apache.org/r/29913/ > > > Diffs > ----- > > include/mesos/resources.hpp f1517b73def9aff4039f95a89f66208ba1d21c0f > src/common/resources.cpp c17e1791130e7d545bb7cdd54d97d65325d3a69e > > Diff: https://reviews.apache.org/r/29911/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
