> On Jan. 21, 2015, 12:02 a.m., Ben Mahler wrote: > > include/mesos/mesos.proto, lines 492-495 > > <https://reviews.apache.org/r/29033/diff/7/?file=827139#file827139line492> > > > > These comments just seem to repeat what's in the name of the field? Do > > they add any clarity or can we pull them out?
Chi, can you have a patch to remove those comments? THanks! - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29033/#review68811 ----------------------------------------------------------- On Jan. 20, 2015, 8:21 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29033/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 8:21 p.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, Jie Yu, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > While we are still working to make RTT less expensive to get, expose total > number of tcp connections in use and in TIME_WAIT. > > > Diffs > ----- > > include/mesos/mesos.proto 859aa2f > src/slave/containerizer/isolators/network/port_mapping.hpp f1e2352 > src/slave/containerizer/isolators/network/port_mapping.cpp 2d81336 > src/slave/flags.hpp 33a0cb6 > src/tests/port_mapping_tests.cpp d57d3e6 > > Diff: https://reviews.apache.org/r/29033/diff/ > > > Testing > ------- > > expanded a test case to test PortMappingStatistics. > > > Thanks, > > Chi Zhang > >
