> On Jan. 5, 2015, 11:07 p.m., Ben Mahler wrote: > > Mind adding some new test cases for the URL overloads?
All of the existing tests use the new URL code paths so all the existing tests are testing these changes. Based on this comment though I realized that I could reuse even more and make the UPID overloads even smaller wrappers. > On Jan. 5, 2015, 11:07 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 43 > > <https://reviews.apache.org/r/29534/diff/1/?file=805386#file805386line43> > > > > Any TODO here for using URL? Great idea. > On Jan. 5, 2015, 11:07 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/http.hpp, lines 529-551 > > <https://reviews.apache.org/r/29534/diff/1/?file=805386#file805386line529> > > > > Any TODO to remove the old http::get and http::post? They are nice helpers that let you do an HTTP request in a single line, versus having to construct the URL first and then modify the URL from the UPID first and then modify the URL with the correct 'path', 'query', etc. Or did you have another idea in mind? > On Jan. 5, 2015, 11:07 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/http.cpp, line 77 > > <https://reviews.apache.org/r/29534/diff/1/?file=805387#file805387line77> > > > > Is this TODO in the right place? This one _does_ have URL as a > > parameter. Removed, thanks! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29534/#review66740 ----------------------------------------------------------- On Jan. 21, 2015, 5:45 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29534/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 5:45 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > 9cf05acbb724ab9af8010d1788621d37a0e48e86 > 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4 > 3rdparty/libprocess/src/tests/http_tests.cpp > c71a91d516214d20d3df4c220e4a39a070db3260 > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 0c80c69bc3457fd70ab745ff8a02be6ec9cfd9e7 > > Diff: https://reviews.apache.org/r/29534/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
