> On Jan. 22, 2015, 11:43 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/http.cpp, line 86 > > <https://reviews.apache.org/r/29534/diff/2/?file=828485#file828485line86> > > > > Do we intend to add a seperate header / impl for https? What's the plan > > looking forward?
The plan for now was just to create an SSL socket if scheme == "https". If we want to create an https namespace in the future we could do that too. > On Jan. 22, 2015, 11:43 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/http.cpp, line 102 > > <https://reviews.apache.org/r/29534/diff/2/?file=828485#file828485line102> > > > > Once URL uses unrestricted union to store ip or domain you won't have > > to protect against this case :-) I'll still have to check something though! > On Jan. 22, 2015, 11:43 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/http.cpp, lines 146-158 > > <https://reviews.apache.org/r/29534/diff/2/?file=828485#file828485line146> > > > > This is the same (painful) code as in the URL streamer. Maybe this can > > be factored out? Yup, once I pull in Cody's changes. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29534/#review69301 ----------------------------------------------------------- On Jan. 21, 2015, 5:45 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29534/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 5:45 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-incubating > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > 9cf05acbb724ab9af8010d1788621d37a0e48e86 > 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4 > 3rdparty/libprocess/src/tests/http_tests.cpp > c71a91d516214d20d3df4c220e4a39a070db3260 > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 0c80c69bc3457fd70ab745ff8a02be6ec9cfd9e7 > > Diff: https://reviews.apache.org/r/29534/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
