----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29600/#review69212 -----------------------------------------------------------
include/mesos/messages.proto <https://reviews.apache.org/r/29600/#comment113830> Can you name the package mesos.internal to signify this is used for internal purposes. You could also move the comment at #40 about why this is exposed, here (and kill the duplicate comment on #76). Also, explicitly specify that the protos in this file are exposed for modules and are not to be used by frameworks directly. src/Makefile.am <https://reviews.apache.org/r/29600/#comment113826> s/need/needed/ - Vinod Kone On Jan. 22, 2015, 1:17 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29600/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 1:17 a.m.) > > > Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. > > > Bugs: MESOS-2096 > https://issues.apache.org/jira/browse/MESOS-2096 > > > Repository: mesos-git > > > Description > ------- > > [2/10] Build Mesos Modules outside Mesos source tree. > > This prepares us to expose src/slave/containerizer/isolator.hpp as > <mesos/slave/isolator.hpp> and src/slave/state.hpp as <mesos/slave/state.hpp> > for inclusion for Isolator modules. > > > Diffs > ----- > > include/mesos/messages.hpp PRE-CREATION > include/mesos/messages.proto PRE-CREATION > src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e > src/common/http.hpp afce7fea334c7bfa57efc48c413bf906a2ebde32 > src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 > src/common/type_utils.cpp fcc9eb0e27a9cbf53f7923f0c051a6578527ec37 > src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be > src/slave/state.hpp 70777cf6ab681c29ca4df601fe47903e1dbdf41f > > Diff: https://reviews.apache.org/r/29600/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
