----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/#review69426 -----------------------------------------------------------
Ship it! Overall, LGTM! src/slave/state.hpp <https://reviews.apache.org/r/29918/#comment114123> OK, that was my bad. Could you please rename those functions: s/write/checkpoint so that we know those internal functions are for the public checkpoint below. src/slave/state.hpp <https://reviews.apache.org/r/29918/#comment114130> const google::protobuf::RepeatedPtrField<Resource>& messages = resources; return write(path, messages); src/slave/state.hpp <https://reviews.apache.org/r/29918/#comment114120> s/wrappers/wrapper src/slave/state.hpp <https://reviews.apache.org/r/29918/#comment114124> s/write/checkpoint src/slave/state.hpp <https://reviews.apache.org/r/29918/#comment114121> Maybe you should call out in the comment that we are using temp + rename to ensure atomicity (all-or-nothing) semantics? src/slave/state.hpp <https://reviews.apache.org/r/29918/#comment114125> s/write/checkpoint - Jie Yu On Jan. 22, 2015, 5 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29918/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 5 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and > Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Introduced a generic checkpoint function. > > > Diffs > ----- > > src/slave/state.hpp 70777cf6ab681c29ca4df601fe47903e1dbdf41f > src/slave/state.cpp a36fa53099300ee03f051b0f5eaaafe9f1da68d1 > src/tests/slave_recovery_tests.cpp 809822e63b05a21418cd9297c927d656d6fd871d > > Diff: https://reviews.apache.org/r/29918/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
