----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/#review69435 -----------------------------------------------------------
src/slave/state.hpp <https://reviews.apache.org/r/29918/#comment114135> One more thought: Can we introduce a third parameter for this function to let users opt out the temp + rename (we can use a default value)? This function is super critical. What if /tmp has too many links? It'll cause slave to flap. For majority of the checkpointing work, we don't need this temp + rename because we know the old file does not exist. What do you think? - Jie Yu On Jan. 22, 2015, 5 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29918/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 5 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and > Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Introduced a generic checkpoint function. > > > Diffs > ----- > > src/slave/state.hpp 70777cf6ab681c29ca4df601fe47903e1dbdf41f > src/slave/state.cpp a36fa53099300ee03f051b0f5eaaafe9f1da68d1 > src/tests/slave_recovery_tests.cpp 809822e63b05a21418cd9297c927d656d6fd871d > > Diff: https://reviews.apache.org/r/29918/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
