----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30514/#review70602 -----------------------------------------------------------
src/master/master.hpp <https://reviews.apache.org/r/30514/#comment115809> nit: s/use/used/ src/master/master.hpp <https://reviews.apache.org/r/30514/#comment115810> unique_ptr? (yes, i'm going to keep suggesting it) src/master/master.cpp <https://reviews.apache.org/r/30514/#comment115812> aren't we going towards 0.22.0 now? should this change be in the sprint? src/master/master.cpp <https://reviews.apache.org/r/30514/#comment115814> worth logging the received pong? src/master/master.cpp <https://reviews.apache.org/r/30514/#comment115815> i wonder if this should be non-optional but set to a very fast default rate. The logic will be much simpler to follow. - Dominic Hamon On Feb. 2, 2015, 10:51 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30514/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2015, 10:51 a.m.) > > > Review request for mesos, Ben Mahler, David Robinson, and Jie Yu. > > > Bugs: MESOS-1148 > https://issues.apache.org/jira/browse/MESOS-1148 > > > Repository: mesos > > > Description > ------- > > The algorithm is simple. All the slave observers share a rate limiter whose > rate is configured via command line. When a slave times out on health check, > a permit is acquired to shutdown the slave *but* the pings are continued to > be sent. If a pong arrives before the permit is satisifed, the shutdown is > cancelled. > > > Diffs > ----- > > src/master/flags.hpp 6c18a1af625311ef149b5877b08f63c2b12c040d > src/master/master.hpp 337e00aa46ea127f3667e3383d631c3fb8e22f30 > src/master/master.cpp 10056861b95ed9453c971787982db7d09f09f323 > src/tests/partition_tests.cpp fea78016268b007590516798eb30ff423fd0ae58 > src/tests/slave_tests.cpp e7e2af63da785644f3f7e6e23607c02be962a2c6 > > Diff: https://reviews.apache.org/r/30514/diff/ > > > Testing > ------- > > make check > > Ran the new tests 100 times > > > Thanks, > > Vinod Kone > >
