-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30514/
-----------------------------------------------------------

(Updated Feb. 3, 2015, 2:39 a.m.)


Review request for mesos, Ben Mahler, David Robinson, and Jie Yu.


Changes
-------

dominic's and jie's comments.


Bugs: MESOS-1148
    https://issues.apache.org/jira/browse/MESOS-1148


Repository: mesos


Description
-------

The algorithm is simple. All the slave observers share a rate limiter whose 
rate is configured via command line. When a slave times out on health check, a 
permit is acquired to shutdown the slave *but* the pings are continued to be 
sent. If a pong arrives before the permit is satisifed, the shutdown is 
cancelled.


Diffs (updated)
-----

  src/master/flags.hpp 6c18a1af625311ef149b5877b08f63c2b12c040d 
  src/master/master.hpp 337e00aa46ea127f3667e3383d631c3fb8e22f30 
  src/master/master.cpp 10056861b95ed9453c971787982db7d09f09f323 
  src/tests/partition_tests.cpp fea78016268b007590516798eb30ff423fd0ae58 
  src/tests/slave_tests.cpp e7e2af63da785644f3f7e6e23607c02be962a2c6 

Diff: https://reviews.apache.org/r/30514/diff/


Testing
-------

make check

Ran the new tests 100 times


Thanks,

Vinod Kone

Reply via email to