----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30590/#review71366 -----------------------------------------------------------
Ship it! src/master/main.cpp <https://reviews.apache.org/r/30590/#comment117067> s/zookeeper/ZooKeeper/ s/urls/URLs/ src/master/main.cpp <https://reviews.apache.org/r/30590/#comment117071> Why do we do determine this here? This should be determined down just before we do 'if (mechanism.isSome())'. Keep the declaration/definition as close to the use. Also, please initialize the value to 'None()'. src/master/main.cpp <https://reviews.apache.org/r/30590/#comment117068> s/Error: // src/master/main.cpp <https://reviews.apache.org/r/30590/#comment117069> s/time./time/ src/master/main.cpp <https://reviews.apache.org/r/30590/#comment117070> Kill newline please. src/master/main.cpp <https://reviews.apache.org/r/30590/#comment117072> s/.// - Benjamin Hindman On Feb. 4, 2015, 12:11 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30590/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 12:11 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1806 > https://issues.apache.org/jira/browse/MESOS-1806 > > > Repository: mesos > > > Description > ------- > > Eventually these will be replaced with --masters which handles both > calculating the master group as well as leader election. Currently > etcd can only be used for master election. > > > Diffs > ----- > > docs/configuration.md 22f9e3db7b0e1691018de5fe3dfea3cb908de4b9 > src/master/main.cpp e5e76ce16646eb0244227104038efeae5fbbbb2b > src/slave/main.cpp 42e46c58ab4b16033ac6a73d127968d0803490aa > > Diff: https://reviews.apache.org/r/30590/diff/ > > > Testing > ------- > > > Thanks, > > Cody Maloney > >
