> On Feb. 6, 2015, 4:01 a.m., Benjamin Hindman wrote: > > src/master/main.cpp, line 158 > > <https://reviews.apache.org/r/30590/diff/1/?file=846786#file846786line158> > > > > Why do we do determine this here? This should be determined down just > > before we do 'if (mechanism.isSome())'. Keep the declaration/definition as > > close to the use. Also, please initialize the value to 'None()'.
Seeing the next review I understand that you wanted to validate that not both --etcd and --zk are set. Why not just do that here and then only set mechanism futher down just before you need to use it. Keep 'if (zk.isSome())' for the replicated log checks (since it's weird to check 'if (mechanism.isSome())' when we're just doing ZooKeeper specific stuff) and then just before we create the contenders do: Option<string> mechanism = zk.isSome() ? zk : etcd; - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30590/#review71366 ----------------------------------------------------------- On Feb. 4, 2015, 12:11 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30590/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 12:11 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1806 > https://issues.apache.org/jira/browse/MESOS-1806 > > > Repository: mesos > > > Description > ------- > > Eventually these will be replaced with --masters which handles both > calculating the master group as well as leader election. Currently > etcd can only be used for master election. > > > Diffs > ----- > > docs/configuration.md 22f9e3db7b0e1691018de5fe3dfea3cb908de4b9 > src/master/main.cpp e5e76ce16646eb0244227104038efeae5fbbbb2b > src/slave/main.cpp 42e46c58ab4b16033ac6a73d127968d0803490aa > > Diff: https://reviews.apache.org/r/30590/diff/ > > > Testing > ------- > > > Thanks, > > Cody Maloney > >
