> On Feb. 17, 2015, 8:18 p.m., Dominic Hamon wrote: > > src/linux/cgroups.cpp, line 1309 > > <https://reviews.apache.org/r/31008/diff/2/?file=866494#file866494line1309> > > > > is it worth trying again in these circumstances?
I thought about that too, but from the man page: 'Each successful read(2) returns an 8-byte integer.", I interpret that as a breach of contract for the kernel to not give exact 8 bytes back. Even for a retry, don't know how to interpret the value read -- the next value? repeat of the previous value? So I report that as a failure. > On Feb. 17, 2015, 8:18 p.m., Dominic Hamon wrote: > > src/linux/cgroups.cpp, line 1314 > > <https://reviews.apache.org/r/31008/diff/2/?file=866494#file866494line1314> > > > > so there's no way for me to reset this promise to try again once it > > fails once? I think in this use case, an error means we are in a pretty bad state. If the user really wants, he could restart a new listener? - Chi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31008/#review72783 ----------------------------------------------------------- On Feb. 17, 2015, 8:10 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31008/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 8:10 p.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu. > > > Bugs: mesos-2136 > https://issues.apache.org/jira/browse/mesos-2136 > > > Repository: mesos > > > Description > ------- > > Refactored EventListener to allow for continuous monitoring of an event. > > > Diffs > ----- > > src/linux/cgroups.hpp bf8efee05b995a37d4e6e7679a493b2d5238aa0b > src/linux/cgroups.cpp b6f75b14dea7609b90627eccdd33ef891ed9d21f > > Diff: https://reviews.apache.org/r/31008/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
