----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31008/#review72866 -----------------------------------------------------------
src/linux/cgroups.cpp <https://reviews.apache.org/r/31008/#comment118987> This is still buggy right? You call fd.get() even if fd is an error? src/linux/cgroups.cpp <https://reviews.apache.org/r/31008/#comment118988> Please update the comments. src/linux/cgroups.cpp <https://reviews.apache.org/r/31008/#comment118986> Indent. - Jie Yu On Feb. 18, 2015, 1:14 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31008/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 1:14 a.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu. > > > Bugs: mesos-2136 > https://issues.apache.org/jira/browse/mesos-2136 > > > Repository: mesos > > > Description > ------- > > Refactored EventListener to allow for continuous monitoring of an event. > > > Diffs > ----- > > src/linux/cgroups.hpp bf8efee05b995a37d4e6e7679a493b2d5238aa0b > src/linux/cgroups.cpp b6f75b14dea7609b90627eccdd33ef891ed9d21f > > Diff: https://reviews.apache.org/r/31008/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
