----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30545/#review73320 -----------------------------------------------------------
src/linux/cgroups.hpp <https://reviews.apache.org/r/30545/#comment119611> nit: indent src/linux/cgroups.hpp <https://reviews.apache.org/r/30545/#comment119612> why is this a friend and not a private method? src/linux/cgroups.cpp <https://reviews.apache.org/r/30545/#comment119613> why does the Listener not create the ListenerProcess in its constructor and therefore own the lifetime of it? - Dominic Hamon On Feb. 20, 2015, 1:37 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30545/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2015, 1:37 p.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2136 > https://issues.apache.org/jira/browse/MESOS-2136 > > > Repository: mesos > > > Description > ------- > > cgroups: added support to listen on memory pressures. > > > Diffs > ----- > > src/Makefile.am d372404d84c9ac0bc49da7407ad366701b9586a6 > src/linux/cgroups.hpp e07772fec11b9bb73a44c54326f24d7ee1e8a64b > src/linux/cgroups.cpp a307e27c5840270e28cced2d5aeb90c6679bff1d > src/tests/cgroups_tests.cpp 9d50a47c939f5f136c85fdcc555459512c6f2259 > src/tests/memory_test_helper.hpp PRE-CREATION > src/tests/memory_test_helper.cpp PRE-CREATION > src/tests/memory_test_helper_main.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/30545/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
