----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30545/#review73605 -----------------------------------------------------------
Ship it! This is great Chi! Giving you a shipit and starting to look at your tests. src/linux/cgroups.hpp <https://reviews.apache.org/r/30545/#comment120002> Can you remind me why you need this forward declaration? src/linux/cgroups.hpp <https://reviews.apache.org/r/30545/#comment120001> +1 You don't need this forward declaration. - Jie Yu On Feb. 23, 2015, 4:43 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30545/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2015, 4:43 a.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2136 > https://issues.apache.org/jira/browse/MESOS-2136 > > > Repository: mesos > > > Description > ------- > > cgroups: added support to listen on memory pressures. > > > Diffs > ----- > > src/linux/cgroups.hpp e07772fec11b9bb73a44c54326f24d7ee1e8a64b > src/linux/cgroups.cpp a307e27c5840270e28cced2d5aeb90c6679bff1d > > Diff: https://reviews.apache.org/r/30545/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
