----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30545/#review77819 -----------------------------------------------------------
Looks good, just a minor API suggestion below. src/linux/cgroups.hpp <https://reviews.apache.org/r/30545/#comment126114> One initial confusion for me was that "Listener" seemed to suggest that it "listens" and tells us when an event occurs. That's generally how we've used the word "listener". However, this is merely keeping a count on behalf of the caller. The caller cannot receive events from this. So, could we just call this a `memory::pressure::Counter`, where you can get the value of the counter as follows: `Future<uint64_t> value = counter.value()`? So rather than having a "Listener" that provides its "counter", we just have a "Counter" that provides its "value". I think that will make this a little more intuitive, thoughts? - Ben Mahler On March 11, 2015, 10:30 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30545/ > ----------------------------------------------------------- > > (Updated March 11, 2015, 10:30 p.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2136 > https://issues.apache.org/jira/browse/MESOS-2136 > > > Repository: mesos > > > Description > ------- > > cgroups: added support to listen on memory pressures. > > > Diffs > ----- > > src/linux/cgroups.hpp e07772fec11b9bb73a44c54326f24d7ee1e8a64b > src/linux/cgroups.cpp a533b319fc75abb0fc45b8f5f473f257912d21ac > > Diff: https://reviews.apache.org/r/30545/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
