> On Feb. 23, 2015, 1:06 p.m., Jie Yu wrote: > > src/tests/port_mapping_tests.cpp, line 67 > > <https://reviews.apache.org/r/31308/diff/3/?file=872983#file872983line67> > > > > Can you paste what the error is? > > > > I am curious why we still need `using namespace mesos::internal::tests` > > when all code are under this namespace? > > Kapil Arya wrote: > We shouldn't need `using namespace mesos::internal` as well. Further, > the `using namespace mesos::internal::slave` is somewhat redundant with a > bunch of `using mesos::internal::slave::*` below. > > It would be helpful to see the error message as well.
PS: Please also take a look at https://reviews.apache.org/r/31301/ which addressed the compilation issues. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31308/#review73602 ----------------------------------------------------------- On Feb. 23, 2015, 12:37 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31308/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2015, 12:37 p.m.) > > > Review request for mesos and Dominic Hamon. > > > Repository: mesos > > > Description > ------- > > see summary > > > Diffs > ----- > > src/tests/port_mapping_tests.cpp a03de23e9833e8e3ec6b4a18b007811ac2b2b764 > > Diff: https://reviews.apache.org/r/31308/diff/ > > > Testing > ------- > > > Thanks, > > Evelina Dumitrescu > >
