> On Feb. 23, 2015, 7 p.m., Kapil Arya wrote: > > src/tests/port_mapping_tests.cpp, line 82 > > <https://reviews.apache.org/r/31308/diff/3/?file=872983#file872983line82> > > > > Just looked at the pastebin file (Thanks!), can we either replace the > > entire `using mesos::internal::slave::*` code block with `using namespace > > mesos::internal::slave` or remove the new code block and add the missing > > members using `using mesos::internal::slave::XYZ`? > > Dominic Hamon wrote: > we really should avoid using namespace. i know we don't but our style > guide says we do. so we should make some token effort on this.
Included: using mesos::internal::slave::Containerizer; using mesos::internal::slave::EXECUTOR_REREGISTER_TIMEOUT; using mesos::internal::slave::Fetcher; using mesos::internal::slave::PortMappingStatistics; using mesos::internal::slave::Slave; using namespace mesos::internal::slave::paths; - Evelina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31308/#review73626 ----------------------------------------------------------- On Feb. 23, 2015, 7:16 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31308/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2015, 7:16 p.m.) > > > Review request for mesos and Dominic Hamon. > > > Repository: mesos > > > Description > ------- > > see summary > > > Diffs > ----- > > src/tests/port_mapping_tests.cpp 62cc9a786c2b54ff6078469a9f159dd300718cf5 > > Diff: https://reviews.apache.org/r/31308/diff/ > > > Testing > ------- > > > Thanks, > > Evelina Dumitrescu > >
