> On Feb. 24, 2015, 8:11 p.m., Jie Yu wrote: > > src/tests/containerizer_tests.cpp, lines 480-485 > > <https://reviews.apache.org/r/30906/diff/6/?file=874348#file874348line480> > > > > s/ASSERT/EXPECT/ > > Vinod Kone wrote: > hmm. Why EXPECT? There is no point in checking the 2nd expectation, if > the first one (metrics.values.count) fails. This, in my mind, is when we > should use ASSERT. > > Jie Yu wrote: > Yeah, I mean we should use EXPECT for the second one.
discussed offline. going with ASSERT as it's more consistent and it doesn't matter if the last expectation of a test is EXPECT or ASSERT. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30906/#review73896 ----------------------------------------------------------- On Feb. 24, 2015, 8:04 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30906/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2015, 8:04 p.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Bugs: MESOS-1690 > https://issues.apache.org/jira/browse/MESOS-1690 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > d4fc8c8fdb94c470892e73ae08796b620b74d17b > src/slave/containerizer/mesos/containerizer.cpp > a587ed38b1df9ef489b4a1b5eb7f16c34d89d156 > src/tests/containerizer_tests.cpp d96a3a8955cb85c6b710c246fc23cb3aa5134920 > src/tests/mesos.hpp e17afe74796ffe148274e278b5fa574e5c1bd34c > > Diff: https://reviews.apache.org/r/30906/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
