----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30906/#review73836 -----------------------------------------------------------
Looks like you forgot to check the metrics in the test:) src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/30906/#comment120241> Thanks! Maybe pass in executorInfo to print executorId and frameworkId as well? src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/30906/#comment120266> Looks like this is a regression introduced in https://reviews.apache.org/r/28141/ I made a comment there and created a ticket: https://issues.apache.org/jira/browse/MESOS-2398 src/tests/containerizer_tests.cpp <https://reviews.apache.org/r/30906/#comment120274> Can you pull that into src/tests/launcher.hpp? src/tests/containerizer_tests.cpp <https://reviews.apache.org/r/30906/#comment120272> Checking metrics? - Jie Yu On Feb. 24, 2015, 5:37 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30906/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2015, 5:37 p.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Bugs: MESOS-1690 > https://issues.apache.org/jira/browse/MESOS-1690 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > d4fc8c8fdb94c470892e73ae08796b620b74d17b > src/slave/containerizer/mesos/containerizer.cpp > a587ed38b1df9ef489b4a1b5eb7f16c34d89d156 > src/tests/containerizer_tests.cpp d96a3a8955cb85c6b710c246fc23cb3aa5134920 > > Diff: https://reviews.apache.org/r/30906/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
