----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review74123 -----------------------------------------------------------
src/common/type_utils.cpp <https://reviews.apache.org/r/30931/#comment120644> You're taking a logging::Flags but you're iterating over non-logging flags (i.e. slave::Flags, master::Flags), that's fairly non-intuitive. Any reason that this `operator <<` can't be defined inside stout for `FlagsBase`? - Ben Mahler On Feb. 24, 2015, 9:30 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30931/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2015, 9:30 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-2323 > https://issues.apache.org/jira/browse/MESOS-2323 > > > Repository: mesos > > > Description > ------- > > Added flags to logs at master and slave startup. > > > Diffs > ----- > > include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45 > src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3 > src/master/master.cpp 713307e1be596651283cc2cc95f114c42ad34a5e > src/slave/slave.cpp d44910838fc479b62200cdfd342ad13524504838 > > Diff: https://reviews.apache.org/r/30931/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
