> On Feb. 25, 2015, 10:54 p.m., Ben Mahler wrote: > > src/common/type_utils.cpp, lines 203-205 > > <https://reviews.apache.org/r/30931/diff/8/?file=873690#file873690line203> > > > > You're taking a logging::Flags but you're iterating over non-logging > > flags (i.e. slave::Flags, master::Flags), that's fairly non-intuitive. > > > > Any reason that this `operator <<` can't be defined inside stout for > > `FlagsBase`?
This makes sense, however I would like to see such functions defind in `.cpp` files, which is not possible for stout. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review74123 ----------------------------------------------------------- On March 16, 2015, 3:20 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30931/ > ----------------------------------------------------------- > > (Updated March 16, 2015, 3:20 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-2323 > https://issues.apache.org/jira/browse/MESOS-2323 > > > Repository: mesos > > > Description > ------- > > Added flags to logs at master and slave startup. > > > Diffs > ----- > > src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1 > src/slave/slave.cpp 0f99e4efb8fa2b96f120a3e49191158ca0364c06 > > Diff: https://reviews.apache.org/r/30931/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
