----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/#review74125 -----------------------------------------------------------
src/slave/containerizer/mesos/launch.hpp <https://reviews.apache.org/r/31444/#comment120646> chroot works on osx, doesn't it? why is this linux only? src/slave/containerizer/mesos/launch.cpp <https://reviews.apache.org/r/31444/#comment120647> please pull this into a private method so it can be easily read. also, potentially unit tested. src/slave/containerizer/mesos/launch.cpp <https://reviews.apache.org/r/31444/#comment120648> you're in the mesos:: namespace already. src/slave/containerizer/mesos/launch.cpp <https://reviews.apache.org/r/31444/#comment120649> s/list/vector/ (or array.. can we use std::array?) src/slave/containerizer/mesos/launch.cpp <https://reviews.apache.org/r/31444/#comment120650> this loop, or the innards, should probably be a private method that can be unittested. src/slave/containerizer/mesos/launch.cpp <https://reviews.apache.org/r/31444/#comment120652> s/Note/NOTE/ src/slave/containerizer/mesos/launch.cpp <https://reviews.apache.org/r/31444/#comment120653> add a jira? src/slave/containerizer/mesos/launch.cpp <https://reviews.apache.org/r/31444/#comment120654> add a jira? src/slave/containerizer/mesos/launch.cpp <https://reviews.apache.org/r/31444/#comment120656> are there any cases when /tmp may get cleaned up and this would disappear under us? would /var/lib/mesos/... be a better location? src/slave/containerizer/mesos/launch.cpp <https://reviews.apache.org/r/31444/#comment120657> aside: why are we returning arbitrary integers instead of boolean or useful errors? src/slave/containerizer/mesos/launch.cpp <https://reviews.apache.org/r/31444/#comment120658> i don't see where we mount flags.directory in to the chroot. did i miss it? - Dominic Hamon On Feb. 25, 2015, 2:48 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31444/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 2:48 p.m.) > > > Review request for mesos, Chi Zhang, Dominic Hamon, Jay Buffington, and Jie > Yu. > > > Bugs: MESOS-2350 > https://issues.apache.org/jira/browse/MESOS-2350 > > > Repository: mesos > > > Description > ------- > > Optionally take a path that the launch helper should chroot to before > exec'ing the executor. It is assumed that the work directory is mounted to > the appropriate location under the chroot. In particular, the path to the > executor must be relative to the chroot. > > Configuration that should be private to the chroot is done during the launch, > e.g. mounting proc and statically configuring basic devices. It is assumed > that other configuration, e.g., preparing the image, mounting in volumes or > persistent resources, is done by the caller. > > Mounts can be made to the chroot (e.g., updating the volumes or persistent > resources) and they will propagate in to the container but mounts made inside > the container will not propagate out to the host. > > It currently assumes that at least {{chroot}}/tmp is writeable and that mount > points {{chroot}}/{tmp,dev,proc,sys} exist in the chroot. > > This is specific to Linux. > > > Diffs > ----- > > src/slave/containerizer/mesos/launch.hpp > 7c8b535746b5ce9add00afef86fdb6faefb5620e > src/slave/containerizer/mesos/launch.cpp > 2f2d60e2011f60ec711d3b29fd2c157e30c83c34 > > Diff: https://reviews.apache.org/r/31444/diff/ > > > Testing > ------- > > Manual testing only so far. This is harder to automate because we need a > self-contained chroot to execute something in... Suggestions welcome. > > > Thanks, > > Ian Downes > >
