----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/#review74388 -----------------------------------------------------------
A lot of tricky manuevers; likely have grasped it fully :) src/slave/containerizer/mesos/launch.cpp <https://reviews.apache.org/r/31444/#comment120964> looks like you do this after executing the preparation scripts. If the scripts changed content relative to the old root, what would happen to the changes after the pivot and chroot? src/slave/containerizer/mesos/launch.cpp <https://reviews.apache.org/r/31444/#comment120960> I think here you mean "pts/ptmx" instead? From my understanding, since you didn't mount the devpts with '-o newinstance' (have you considered it, btw), is this step still necessary? From Documentation/filesystems/devpts.txt: " 2. To effectively use multi-instance mode (i.e -o newinstance is specified) administrators or startup scripts should "redirect" open of /dev/ptmx to /dev/pts/ptmx using either a bind mount or symlink. $ mount -t devpts -o newinstance devpts /dev/pts followed by either $ rm /dev/ptmx $ ln -s pts/ptmx /dev/ptmx $ chmod 666 /dev/pts/ptmx or $ mount -o bind /dev/pts/ptmx /dev/ptmx " - Chi Zhang On Feb. 25, 2015, 10:48 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31444/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 10:48 p.m.) > > > Review request for mesos, Chi Zhang, Dominic Hamon, Jay Buffington, and Jie > Yu. > > > Bugs: MESOS-2350 > https://issues.apache.org/jira/browse/MESOS-2350 > > > Repository: mesos > > > Description > ------- > > Optionally take a path that the launch helper should chroot to before > exec'ing the executor. It is assumed that the work directory is mounted to > the appropriate location under the chroot. In particular, the path to the > executor must be relative to the chroot. > > Configuration that should be private to the chroot is done during the launch, > e.g. mounting proc and statically configuring basic devices. It is assumed > that other configuration, e.g., preparing the image, mounting in volumes or > persistent resources, is done by the caller. > > Mounts can be made to the chroot (e.g., updating the volumes or persistent > resources) and they will propagate in to the container but mounts made inside > the container will not propagate out to the host. > > It currently assumes that at least {{chroot}}/tmp is writeable and that mount > points {{chroot}}/{tmp,dev,proc,sys} exist in the chroot. > > This is specific to Linux. > > > Diffs > ----- > > src/slave/containerizer/mesos/launch.hpp > 7c8b535746b5ce9add00afef86fdb6faefb5620e > src/slave/containerizer/mesos/launch.cpp > 2f2d60e2011f60ec711d3b29fd2c157e30c83c34 > > Diff: https://reviews.apache.org/r/31444/diff/ > > > Testing > ------- > > Manual testing only so far. This is harder to automate because we need a > self-contained chroot to execute something in... Suggestions welcome. > > > Thanks, > > Ian Downes > >
