----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31470/#review74510 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp <https://reviews.apache.org/r/31470/#comment121096> you could also append the actual number, or print out the value passed in for easier debugging. 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp <https://reviews.apache.org/r/31470/#comment121097> return stream << ip.address() << "/" << ip.prefix(); 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp <https://reviews.apache.org/r/31470/#comment121098> too soon. you'll free this then access addr which is a pointer in ifa which is part of ifaddr. make the call to try to create the IPNetwork, then free ifaddr before checking the error. - Dominic Hamon On Feb. 26, 2015, 10:52 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31470/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 10:52 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van > Remoortere, and Niklas Nielsen. > > > Repository: mesos > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp > 3293086a009a8f7cf7bd343eb7d3e85623636550 > 3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp > fb98317a68986cb1228c584a8cd83b07737895a8 > > Diff: https://reviews.apache.org/r/31470/diff/ > > > Testing > ------- > > > Thanks, > > Evelina Dumitrescu > >
