> On Feb. 27, 2015, 10:47 a.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 140 > > <https://reviews.apache.org/r/31470/diff/2/?file=879658#file879658line140> > > > > any reason change the prefix from size_t to int? Prefix cannot be > > negative, right?
this was my feedback. http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Integer_Types you should never use unsigned types to state that a number can't be negative, instead use assertions. it's too easy to accidentally change from int to unsigned and back without getting a compiler warning. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31470/#review74535 ----------------------------------------------------------- On Feb. 26, 2015, 10:52 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31470/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 10:52 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van > Remoortere, and Niklas Nielsen. > > > Repository: mesos > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp > 3293086a009a8f7cf7bd343eb7d3e85623636550 > 3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp > fb98317a68986cb1228c584a8cd83b07737895a8 > > Diff: https://reviews.apache.org/r/31470/diff/ > > > Testing > ------- > > > Thanks, > > Evelina Dumitrescu > >
