----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30546/#review74647 -----------------------------------------------------------
src/slave/containerizer/isolators/cgroups/mem.hpp <https://reviews.apache.org/r/30546/#comment121289> why is this header treated like something installed while the other slave headers are treated as local dev headers? consistency rules here.. this should be lower down and "slave/isolator.hpp" i believe. src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/30546/#comment121298> instead of a list, why not a vector where it is indexed by 'LOW', 'MEDIUM' and 'CRITICAL'? then in the continuation you don't have to assume the ordering in the list. src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/30546/#comment121293> a separate failure for each listener might help debugging down the road. src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/30546/#comment121292> await or collect? src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/30546/#comment121291> the general rule is this would be _pressureListen src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/30546/#comment121295> cbegin is only in c++11 .. is it definitely in g++-4.6? src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/30546/#comment121296> iterator->isReady() is clearer src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/30546/#comment121299> s/> >/>>/ - Dominic Hamon On Feb. 27, 2015, 5:43 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30546/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 5:43 p.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2136 > https://issues.apache.org/jira/browse/MESOS-2136 > > > Repository: mesos > > > Description > ------- > > MemIsolator: expose memory pressures for containers. > > > Diffs > ----- > > include/mesos/mesos.proto 9df972d750ce1e4a81d2e96cc508d6f83cad2fc8 > src/slave/containerizer/isolators/cgroups/mem.hpp > a00f723de61b9bccd76a2948b6d14fde7a993a8d > src/slave/containerizer/isolators/cgroups/mem.cpp > 6299ca4ba01b65daa3d75c64150e2738e32b841e > src/tests/slave_recovery_tests.cpp 53adae0118a26e6d25a9ff20c6374cc8e73275b1 > > Diff: https://reviews.apache.org/r/30546/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
