> On March 11, 2015, 12:02 a.m., Jie Yu wrote: > > src/tests/slave_recovery_tests.cpp, lines 3568-3569 > > <https://reviews.apache.org/r/30546/diff/2/?file=881465#file881465line3568> > > > > I suggest moving this test to cgroups_isolator_tests.cpp, or even > > create a cgroups_memory_isolator_tests.cpp and move tests accordingly. > > > > I don't think we should move all slave recovery related tests to a > > single file, especially the test is for testing the slave recovery for a > > special isolator.
as discussed: left a TODO. will do a separate patch for that. > On March 11, 2015, 12:02 a.m., Jie Yu wrote: > > src/tests/slave_recovery_tests.cpp, lines 3667-3670 > > <https://reviews.apache.org/r/30546/diff/2/?file=881465#file881465line3667> > > > > Can you test the slave recovery in a separate test? dropped as discussed. > On March 11, 2015, 12:02 a.m., Jie Yu wrote: > > src/tests/slave_recovery_tests.cpp, lines 3661-3662 > > <https://reviews.apache.org/r/30546/diff/2/?file=881465#file881465line3661> > > > > Just do a > > > > ``` > > ASSERT_LE(waited, Seconds(5)); > > ``` i dropped the logging but kept the EXPECT to allow further clean up if it failed. It is also consistent with other tests where this patten is used. - Chi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30546/#review75951 ----------------------------------------------------------- On Feb. 28, 2015, 1:43 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30546/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2015, 1:43 a.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2136 > https://issues.apache.org/jira/browse/MESOS-2136 > > > Repository: mesos > > > Description > ------- > > MemIsolator: expose memory pressures for containers. > > > Diffs > ----- > > include/mesos/mesos.proto 9df972d750ce1e4a81d2e96cc508d6f83cad2fc8 > src/slave/containerizer/isolators/cgroups/mem.hpp > a00f723de61b9bccd76a2948b6d14fde7a993a8d > src/slave/containerizer/isolators/cgroups/mem.cpp > 6299ca4ba01b65daa3d75c64150e2738e32b841e > src/tests/slave_recovery_tests.cpp 53adae0118a26e6d25a9ff20c6374cc8e73275b1 > > Diff: https://reviews.apache.org/r/30546/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
