> On March 2, 2015, 6:50 p.m., Jie Yu wrote: > > src/linux/routing/queueing/fq_codel.cpp, line 107 > > <https://reviews.apache.org/r/31502/diff/1/?file=879068#file879068line107> > > > > What if some one already installed an egress qdisc on the link? I think > > this is much more likely than ingress qdisc. > > > > Maybe use a handle that's more unlikely to be picked (e.g., Handle(0x1, > > 0x800)) for now and add a TODO saying that we may want to expose the handle > > in the interfaces and instead let the user choose the handle. > > Cong Wang wrote: > Root qdisc handle has to be X:0, so we can't change the minor and we > can't add more than one root qdisc's. Currently we just fail if another qdisc > is already installed, as in my comment in port_mapping.c (in the last patch), > the TODO is disabling this feature and continuing.
Could you please add what you've just said to the comment in the code? That's useful for us to understand the code. THanks! - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31502/#review74774 ----------------------------------------------------------- On Feb. 27, 2015, 9:38 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31502/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 9:38 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2422 > https://issues.apache.org/jira/browse/MESOS-2422 > > > Repository: mesos > > > Description > ------- > > Fq_codel qdisc is needed for egress flow classification. Internally fq_codel > defines its own flows, and it allows us to specifiy the rule to classify the > flows with tc filters attached on it. By default it has 1024 flows, much more > than the number of containers we could create on a single host. > > > Diffs > ----- > > src/Makefile.am 17d0d7aa7361c3a373f6863d36b0a4767f5c05c4 > src/linux/routing/queueing/fq_codel.hpp PRE-CREATION > src/linux/routing/queueing/fq_codel.cpp PRE-CREATION > src/tests/routing_tests.cpp 3cda6ab8c1ad24e4b7d0b9aeda2abc595fc857a5 > > Diff: https://reviews.apache.org/r/31502/diff/ > > > Testing > ------- > > Run the testcase. > > > Thanks, > > Cong Wang > >
