> On March 9, 2015, 6:54 p.m., Jie Yu wrote: > > src/linux/routing/queueing/fq_codel.cpp, line 77 > > <https://reviews.apache.org/r/31502/diff/3/?file=889438#file889438line77> > > > > Wrap comments in 70 char width: > > > > ``` > > // We don't ... > > // limit 10240p > > // flows 1024 > > // quantum 1514 > > // ... > > > > return Nothing(); > > ```
Just FYI, this is the 'tc qd show' cmdline output, I think we should keep it as it is. - Cong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31502/#review75740 ----------------------------------------------------------- On March 9, 2015, 6:28 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31502/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 6:28 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2422 > https://issues.apache.org/jira/browse/MESOS-2422 > > > Repository: mesos > > > Description > ------- > > Fq_codel qdisc is needed for egress flow classification. Internally fq_codel > defines its own flows, and it allows us to specifiy the rule to classify the > flows with tc filters attached on it. By default it has 1024 flows, much more > than the number of containers we could create on a single host. > > > Diffs > ----- > > src/Makefile.am d299f07 > src/linux/routing/queueing/fq_codel.hpp PRE-CREATION > src/linux/routing/queueing/fq_codel.cpp PRE-CREATION > src/tests/routing_tests.cpp 3cda6ab > > Diff: https://reviews.apache.org/r/31502/diff/ > > > Testing > ------- > > Run the testcase. > > > Thanks, > > Cong Wang > >
