> On March 3, 2015, 6:39 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, lines 211-213
> > <https://reviews.apache.org/r/31471/diff/4/?file=882869#file882869line211>
> >
> > Fix the indent please
>
> Evelina Dumitrescu wrote:
> I put the parameters on different lines each, I don't understand what's
> wrong
Either
```
ABORT(
"xxx" +
stringify(xxx) +
stringify(xxx));
```
Or
```
ABORT("XXX" +
stringify(xxx) +
stringify(xxx));
```
see Case 2 in:
https://github.com/apache/mesos/blob/master/docs/mesos-c%2B%2B-style-guide.md#function-definitioninvocation
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/#review74987
-----------------------------------------------------------
On March 3, 2015, 11:27 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31471/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 11:27 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van
> Remoortere, and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp
> 0cd7cb526a3a2514b3b54552253dfa8919e948d0
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
> 9635bbc6f7dae1d75a780069fcc60fb706221053
> 3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp
> fb98317a68986cb1228c584a8cd83b07737895a8
>
> Diff: https://reviews.apache.org/r/31471/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
