-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30952/#review75585
-----------------------------------------------------------



src/master/master.cpp
<https://reviews.apache.org/r/30952/#comment122779>

    Is there a test for this? If not, can you write one?
    
    Also add a TODO in the old driver to remove this code.



src/master/validation.cpp
<https://reviews.apache.org/r/30952/#comment122775>

    Can this made a CHECK now?


- Vinod Kone


On March 3, 2015, 6:32 a.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30952/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 6:32 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2290
>     https://issues.apache.org/jira/browse/MESOS-2290
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> There is a scheduler validation 
> (https://github.com/apache/mesos/blob/master/src/scheduler/scheduler.cpp#L275)
>  missing in master. See motivation on MESOS-2288.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp dae0955 
>   src/master/validation.cpp 2f2e4ea 
> 
> Diff: https://reviews.apache.org/r/30952/diff/
> 
> 
> Testing
> -------
> 
> make check and distcheck. Tests will be added with new HTTP API endpoints 
> tests.
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Reply via email to