> On March 7, 2015, 12:49 a.m., Vinod Kone wrote: > > src/master/master.cpp, lines 2542-2545 > > <https://reviews.apache.org/r/30952/diff/4/?file=882660#file882660line2542> > > > > Is there a test for this? If not, can you write one? > > > > Also add a TODO in the old driver to remove this code.
We will have to add unit tests for this kind of validations with the new API. Right now master tests use the DEFAULT_EXECUTOR_INFO which do not have framework_id. - Isabel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30952/#review75585 ----------------------------------------------------------- On March 23, 2015, 2:34 a.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30952/ > ----------------------------------------------------------- > > (Updated March 23, 2015, 2:34 a.m.) > > > Review request for mesos, Jie Yu, Joris Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-2290 > https://issues.apache.org/jira/browse/MESOS-2290 > > > Repository: mesos-incubating > > > Description > ------- > > There is a scheduler validation > (https://github.com/apache/mesos/blob/master/src/scheduler/scheduler.cpp#L275) > missing in master. See motivation on MESOS-2288. > > > Diffs > ----- > > src/master/master.cpp dccd7c6 > src/master/validation.cpp 2f2e4ea > src/scheduler/scheduler.cpp 584b042 > > Diff: https://reviews.apache.org/r/30952/diff/ > > > Testing > ------- > > make check and distcheck. Tests will be added with new HTTP API endpoints > tests. > > > Thanks, > > Isabel Jimenez > >
