----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32198/#review76908 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp <https://reviews.apache.org/r/32198/#comment124618> Right now, these tests appear a bit random to me. Can you explain the idea on why you came up with 8 tests? Maybe we could have some simple top-level object comparison first `{"foo": "foo"} != {"bar": "bar"}` to be more explicit. Then one or two deeper nested variants? - Till Toenshoff On March 18, 2015, 10:46 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32198/ > ----------------------------------------------------------- > > (Updated March 18, 2015, 10:46 a.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad, > Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-2510 > https://issues.apache.org/jira/browse/MESOS-2510 > > > Repository: mesos > > > Description > ------- > > For consistency, adds a non equal operator to the json objects. > > It also adds tests to the equality operators. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp > 334c898906018be6e663f53815abbe047806b95c > 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp > f60d1bbe60f2e2b6460c06bba98e8b85ebb6a3f9 > > Diff: https://reviews.apache.org/r/32198/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
