> On March 18, 2015, 5:36 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp, lines 252-263 > > <https://reviews.apache.org/r/32198/diff/1/?file=898923#file898923line252> > > > > Right now, these tests appear a bit random to me. Can you explain the > > idea on why you came up with 8 tests? > > > > Maybe we could have some simple top-level object comparison first > > `{"foo": "foo"} != {"bar": "bar"}` to be more explicit. Then one or two > > deeper nested variants? > > Alexander Rojas wrote: > It is not random, it just has one element of each type you can have as a > json, an array, a boolean, a null a string and a nested object. It just > ensures that the visitor will call all of its methods in turn.
Thanks for clarifying. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32198/#review76908 ----------------------------------------------------------- On March 23, 2015, 2:19 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32198/ > ----------------------------------------------------------- > > (Updated March 23, 2015, 2:19 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad, > Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-2510 > https://issues.apache.org/jira/browse/MESOS-2510 > > > Repository: mesos > > > Description > ------- > > For consistency, adds a non equal operator to the json objects. > > It also adds tests to the equality operators. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp > 334c898906018be6e663f53815abbe047806b95c > 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp > f60d1bbe60f2e2b6460c06bba98e8b85ebb6a3f9 > > Diff: https://reviews.apache.org/r/32198/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
