> On March 17, 2015, 9:04 p.m., Kapil Arya wrote: > > src/examples/test_allocator_module.cpp, line 40 > > <https://reviews.apache.org/r/31267/diff/3/?file=894483#file894483line40> > > > > s/HierarchicalDRFAllocator/HierarchicalDRFAllocator()/
There should be no difference in this case: https://stackoverflow.com/questions/620137/do-the-parentheses-after-the-type-name-make-a-difference-with-new. For consistency with instantiation on stack, let's go for original (without brackets) version. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31267/#review76810 ----------------------------------------------------------- On March 13, 2015, 9:48 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31267/ > ----------------------------------------------------------- > > (Updated March 13, 2015, 9:48 p.m.) > > > Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. > > > Bugs: MESOS-2160 > https://issues.apache.org/jira/browse/MESOS-2160 > > > Repository: mesos > > > Description > ------- > > The test allocator module is a built-in HierarchicalDRFAllocator put in a > module. > > > Diffs > ----- > > src/Makefile.am 3059818231c46484039d179cd6916932eff6cd68 > src/examples/test_allocator_module.cpp PRE-CREATION > src/tests/module.hpp 65e567f21744d9a2b07b8680d45bcd1ea47f9508 > src/tests/module.cpp b81144f56e94034feecf3a6a4992af078cf60a81 > > Diff: https://reviews.apache.org/r/31267/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.5, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >
