> On March 24, 2015, 7:07 a.m., Michael Park wrote: > > src/tests/module.cpp, line 141 > > <https://reviews.apache.org/r/31267/diff/4/?file=903021#file903021line141> > > > > Looking at the `Isolator` example which has `Cpu` and `Mem` isolators, > > it seems to me like we want `s/testdrfalloactor/testallocator/` here.
No very sure about this issue, as I see it, we can have multiple isolators, but you cannot have more than one allocator (though I may be wrong). In that sense, it makes sense to have a test for each of them. Just wondering how that will work if there are more than one allocator module that needs to be tested. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31267/#review77531 ----------------------------------------------------------- On March 23, 2015, 3:05 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31267/ > ----------------------------------------------------------- > > (Updated March 23, 2015, 3:05 p.m.) > > > Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. > > > Bugs: MESOS-2160 > https://issues.apache.org/jira/browse/MESOS-2160 > > > Repository: mesos > > > Description > ------- > > The test allocator module is a built-in HierarchicalDRFAllocator put in a > module. > > > Diffs > ----- > > src/Makefile.am 7a06c7028eca8164b1f5fdea6a7ecd37ee6826bb > src/examples/test_allocator_module.cpp PRE-CREATION > src/tests/module.hpp 65e567f21744d9a2b07b8680d45bcd1ea47f9508 > src/tests/module.cpp b81144f56e94034feecf3a6a4992af078cf60a81 > > Diff: https://reviews.apache.org/r/31267/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.5, CentOS 7.0) > > > Thanks, > > Alexander Rukletsov > >
