> On March 24, 2015, 8:01 p.m., Vinod Kone wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 1512 > > <https://reviews.apache.org/r/32426/diff/1/?file=903757#file903757line1512> > > > > Why delete from linkees here? AFAICT, it's not used after this loop.
Yes, but i would rather keep linkers and linkees in sync. > On March 24, 2015, 8:01 p.m., Vinod Kone wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 1813 > > <https://reviews.apache.org/r/32426/diff/1/?file=903757#file903757line1813> > > > > What happens if the slave dies before doing the symlink? It's OK because we will not even try to recover that container because veth does not exist. MESOS-2547 trackes the removal of stale bind mount handles. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32426/#review77596 ----------------------------------------------------------- On March 24, 2015, 2:44 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32426/ > ----------------------------------------------------------- > > (Updated March 24, 2015, 2:44 a.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-2528 > https://issues.apache.org/jira/browse/MESOS-2528 > > > Repository: mesos > > > Description > ------- > > Symlink the namespace handle with ContainerID for the port mapping isolator. > > See ticket for details. This patch will allow a smooth upgrade (i.e., rolling > foward and back are both safe). > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.hpp > 4dd066a47d43cb1d52f93294d86309151738743e > src/slave/containerizer/isolators/network/port_mapping.cpp > 4bf0adeeac1cb6fe59f9c2ca8d5980b1500f5ddd > src/tests/port_mapping_tests.cpp 8192deac8d9b7ea1896bb62a8b5961ef90326fa4 > > Diff: https://reviews.apache.org/r/32426/diff/ > > > Testing > ------- > > sudo make check > > Many existing tests should already capture the regression. For example, > ROOT_CleanUpOrphanTest checks if the bind mount dir is empty after the > container is destroyed. > > Will add a compatibility test tomorrow. > > > Thanks, > > Jie Yu > >
