-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32426/
-----------------------------------------------------------
(Updated March 26, 2015, 10:56 p.m.)
Review request for mesos, Chi Zhang, Ian Downes, and Vinod Kone.
Changes
-------
Review comments. Added a test.
Bugs: MESOS-2528
https://issues.apache.org/jira/browse/MESOS-2528
Repository: mesos
Description
-------
Symlink the namespace handle with ContainerID for the port mapping isolator.
See ticket for details. This patch will allow a smooth upgrade (i.e., rolling
foward and back are both safe).
Diffs (updated)
-----
src/slave/containerizer/isolators/network/port_mapping.hpp
4dd066a47d43cb1d52f93294d86309151738743e
src/slave/containerizer/isolators/network/port_mapping.cpp
4bf0adeeac1cb6fe59f9c2ca8d5980b1500f5ddd
src/tests/port_mapping_tests.cpp 8fc854e77ef6b5ebb76f25a9c9691f5a0d8c872b
Diff: https://reviews.apache.org/r/32426/diff/
Testing
-------
sudo make check
Many existing tests should already capture the regression. For example,
ROOT_CleanUpOrphanTest checks if the bind mount dir is empty after the
container is destroyed.
Will add a compatibility test tomorrow.
Thanks,
Jie Yu