> On March 27, 2015, 3:22 p.m., Alexander Rojas wrote: > > src/scheduler/scheduler.cpp, lines 679-680 > > <https://reviews.apache.org/r/32505/diff/1/?file=906104#file906104line679> > > > > Do you mind adding a comment why an exited executor is always marked as > > a failure? It is not clear to me.
This is the only event present in mesos.proto to capture terminated executors. I agree that a 'FAILURE' event is misleading. I've added a comment on the design doc. Will also add it on the proto. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/#review78050 ----------------------------------------------------------- On March 31, 2015, 12:09 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32505/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 12:09 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1127 and MESOS-330 > https://issues.apache.org/jira/browse/MESOS-1127 > https://issues.apache.org/jira/browse/MESOS-330 > > > Repository: mesos > > > Description > ------- > > This is a new call added to explicitly shutdown an executor. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 783a63ad1cc0edd86605d638046fb959cb6e97e8 > src/master/master.hpp 05be911734b8d70c9fa5f3b4a275e8b610621fc5 > src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b > src/messages/messages.proto 97c45c01dfcea38b1ae555c036d61e10c152c2c8 > src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a > src/slave/slave.hpp 19e6b44bc344c0ca509674803f401cbb4e1f47ae > src/slave/slave.cpp 0f70ebafb0f5b16c560decc66e22a43a52732d09 > src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 > > Diff: https://reviews.apache.org/r/32505/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
