----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/#review79369 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/32505/#comment128640> How about moving this after `Master::reconcile()`? src/tests/scheduler_tests.cpp <https://reviews.apache.org/r/32505/#comment128645> s/> >/>> here and below. src/tests/scheduler_tests.cpp <https://reviews.apache.org/r/32505/#comment128648> Mind leaving a comment why we expect failure here? Maybe it makes sense to write a short comment to the test as well. - Alexander Rukletsov On April 3, 2015, 11:38 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32505/ > ----------------------------------------------------------- > > (Updated April 3, 2015, 11:38 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1127 and MESOS-330 > https://issues.apache.org/jira/browse/MESOS-1127 > https://issues.apache.org/jira/browse/MESOS-330 > > > Repository: mesos > > > Description > ------- > > This is a new call added to explicitly shutdown an executor. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 783a63ad1cc0edd86605d638046fb959cb6e97e8 > src/master/master.hpp 05be911734b8d70c9fa5f3b4a275e8b610621fc5 > src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b > src/messages/messages.proto 97c45c01dfcea38b1ae555c036d61e10c152c2c8 > src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a > src/slave/slave.hpp 19e6b44bc344c0ca509674803f401cbb4e1f47ae > src/slave/slave.cpp 0f70ebafb0f5b16c560decc66e22a43a52732d09 > src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 > > Diff: https://reviews.apache.org/r/32505/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
