----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30546/#review78290 -----------------------------------------------------------
The code looks good to me. See my comments for the tests. src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/30546/#comment126817> Can you reorder these two just to be consistent. src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/30546/#comment126820> const Future<uint64_t>& value src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/30546/#comment126818> << containerId src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/30546/#comment126826> Can you kill this TODO and create a memory_pressure_tests.cpp. Instead of testing slave recovery and normal statistics retriving in one test, consider separating them into two tests: 1) TEST_F(MemoryPressureMesosTest, Statistics) 2) TEST_F(MemoryPressureMesosTest, SlaveRecovery) src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/30546/#comment126823> I would rather just do a ASSERT here because the likelyhood of dd being not available is small. It simplies the test. src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/30546/#comment126824> No need to have this temp variable src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/30546/#comment126825> Why do you need a temp file? Just give it a random name since you are the only one using the sandbox. src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/30546/#comment126827> What do you want to test here? Is it possible that this loop gets stuck for 5 seconds? - Jie Yu On March 31, 2015, 12:02 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30546/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 12:02 a.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2136 > https://issues.apache.org/jira/browse/MESOS-2136 > > > Repository: mesos > > > Description > ------- > > MemIsolator: expose memory pressures for containers. > > > Diffs > ----- > > include/mesos/mesos.proto 3c592d5ab3092ecbeddfaff95e0c1addc3ac58f8 > src/slave/containerizer/isolators/cgroups/mem.hpp > a00f723de61b9bccd76a2948b6d14fde7a993a8d > src/slave/containerizer/isolators/cgroups/mem.cpp > eaeb30164e8ae8c0a703683b7cc0bf1851760c95 > src/tests/slave_recovery_tests.cpp 87f4a6aab27d142fa8eb7a6571f684a6ce59687e > > Diff: https://reviews.apache.org/r/30546/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
