> On March 25, 2015, 12:12 a.m., Ian Downes wrote: > > src/slave/containerizer/isolators/cgroups/mem.cpp, lines 471-474 > > <https://reviews.apache.org/r/30546/diff/4/?file=899177#file899177line471> > > > > okay, so if you want to continue to call __usage even with a failure > > then why not: > > > > listener->counter() > > .onAny()
onAny doesn't return, as discussed offline. - Chi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30546/#review77687 ----------------------------------------------------------- On March 27, 2015, 3:24 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30546/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 3:24 a.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2136 > https://issues.apache.org/jira/browse/MESOS-2136 > > > Repository: mesos > > > Description > ------- > > MemIsolator: expose memory pressures for containers. > > > Diffs > ----- > > include/mesos/mesos.proto 3c592d5ab3092ecbeddfaff95e0c1addc3ac58f8 > src/slave/containerizer/isolators/cgroups/mem.hpp > a00f723de61b9bccd76a2948b6d14fde7a993a8d > src/slave/containerizer/isolators/cgroups/mem.cpp > eaeb30164e8ae8c0a703683b7cc0bf1851760c95 > src/tests/slave_recovery_tests.cpp 87f4a6aab27d142fa8eb7a6571f684a6ce59687e > > Diff: https://reviews.apache.org/r/30546/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
