----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/#review78422 -----------------------------------------------------------
src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32655/#comment127087> Could you make it a bit more explict to say this variable is mesos-containerizer *path*? is the indent off by 1? ;) - Chi Zhang On March 31, 2015, 5:35 a.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32655/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 5:35 a.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. > > > Bugs: mesos-2332 > https://issues.apache.org/jira/browse/mesos-2332 > > > Repository: mesos > > > Description > ------- > > Refactor out launchHelper to make is usable outside PortMappingIsolatorTest > class > > > Diffs > ----- > > src/tests/port_mapping_tests.cpp f4124c3 > > Diff: https://reviews.apache.org/r/32655/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
