----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/#review78861 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.hpp <https://reviews.apache.org/r/32655/#comment127938> We favor `const char foobar[]`. src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32655/#comment127939> directory and name? src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32655/#comment127943> Move down to where used. Why change and introduce a variable? src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32655/#comment127944> Not yours, but why is `preparation` an `Option`? And why don't we check it's some? src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32655/#comment127942> Why the change from std{in,out,err}? src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32655/#comment127941> keep the newline? - Ian Downes On April 3, 2015, 3:36 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32655/ > ----------------------------------------------------------- > > (Updated April 3, 2015, 3:36 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. > > > Bugs: mesos-2591 > https://issues.apache.org/jira/browse/mesos-2591 > > > Repository: mesos > > > Description > ------- > > Refactor out launchHelper to make is usable outside PortMappingIsolatorTest > class > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > ae61a0fcd19f2ba808624312401f020121baf5d4 > src/slave/containerizer/mesos/containerizer.cpp > e4136095fca55637864f495098189ab3ad8d8fe7 > src/tests/port_mapping_tests.cpp 55a5e69ed818fd0856179026e3deb889236fea77 > > Diff: https://reviews.apache.org/r/32655/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
