----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32656/#review78432 -----------------------------------------------------------
src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32656/#comment127117> how about also extract this out to be a 'helperPath', like what you did for launchHelper in the other patch? src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32656/#comment127116> having no output here isn't expected; why delay reporting it? - Chi Zhang On March 31, 2015, 6:12 a.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32656/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 6:12 a.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. > > > Bugs: mesos-2332 > https://issues.apache.org/jira/browse/mesos-2332 > > > Repository: mesos > > > Description > ------- > > Refactor statistics helper out of PortMappingIsolatorTest for easier reuse. > > > Diffs > ----- > > src/tests/port_mapping_tests.cpp f4124c3 > > Diff: https://reviews.apache.org/r/32656/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
