----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32656/#review78852 -----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.hpp <https://reviews.apache.org/r/32656/#comment127929> A quick grep of the code base indicates we mostly favor "const char foobar[]" src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32656/#comment127937> what about just "directory" and "name"? src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32656/#comment127935> Move where used, but see below. src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32656/#comment127936> Please fix any s/> >/>>/ when changing code. src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32656/#comment127931> IMHO this is clearer: ```c++ Try<JSON::Object> parse = JSON::parse<>(); if (parse.isError()) { // Comment on why we return on empty object when parsing fails return JSON::Object(); } return parse.get(); ``` - Ian Downes On April 3, 2015, 3:36 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32656/ > ----------------------------------------------------------- > > (Updated April 3, 2015, 3:36 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. > > > Bugs: mesos-2591 > https://issues.apache.org/jira/browse/mesos-2591 > > > Repository: mesos > > > Description > ------- > > Refactor statistics helper out of PortMappingIsolatorTest for easier reuse. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.hpp > 466cd82e69665af217d61392b739b9bba16e1e13 > src/slave/containerizer/isolators/network/port_mapping.cpp > ccdc44f465f204f674b859c429ba1a6ada51cd88 > src/tests/port_mapping_tests.cpp 58709b5a0ac58f13985dcc4b71250ec41487ff18 > > Diff: https://reviews.apache.org/r/32656/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
