We do accept Pull-Requests <https://github.com/apache/mesos/pulls> for small patches, especially (markdown) documentation patches; but for larger code changes we prefer the issue tracking, multi-line comments, and incremental diffs provided by ReviewBoard.
On Tue, Mar 31, 2015 at 10:55 AM, haosdent <[email protected]> wrote: > If it is possible, I suggest use the workflow like > https://github.com/apache/spark: Submit push request to github. > > On Wed, Apr 1, 2015 at 1:49 AM, Vinod Kone <[email protected]> wrote: > > > Are you still having issue with this? > > > > I've seen this issue before when my branch depends on a file that was > > recently committed. The mesos repo used by ReviewBoard is a mirror of the > > canonical mesos repo and there is sometimes lag in the commits from the > > latter reaching the former. But the issue usually resolves by itself once > > the new commits are mirrored. > > > > On Sun, Mar 29, 2015 at 9:58 AM, Aditi Dixit <[email protected]> > > wrote: > > > > > Thanks for the response Alex. > > > I checked the .reviewboardrc file and its parameters were the same that > > you > > > mentioned. I had also taken care to rebase the so that my commit was > over > > > the current master. > > > While trying to submit a patch manually through the ReviewBoard UI, I > was > > > getting an error that "The file "src/master/master.hpp" (revision > > 744886e) > > > was not found in the repository". > > > Is the format of making a patch something other than git format-patch > -n > > ? > > > Regards, > > > Aditi Dixit > > > > > > > > > -- > Best Regards, > Haosdent Huang >
