> On March 23, 2015, 10:10 p.m., Jay Buffington wrote: > > src/slave/containerizer/mesos/launch.cpp, line 107 > > <https://reviews.apache.org/r/31444/diff/2/?file=898403#file898403line107> > > > > This list-initialization doesn't work in gcc 4.4.7. That's the version > > I had with a stock centos 6.4 box. > > > > gcc 4.4.7 currently compiles the master branch on > > github.com/apache/mesos so this is bumping up the minimum gcc required > > version. I guess this c++11 feature isn't used anywhere else in the code? > > > > I installed gcc 4.8.2 (and updated bintools) and it compiled.
Initializer lists are supported in 4.4.7, see https://gcc.gnu.org/gcc-4.4/cxx0x_status.html, but local types for template arguments are not, see the same link. I'll pull those out into an internal namespace and add a TODO for when we get off supporting 4.4.7. > On March 23, 2015, 10:10 p.m., Jay Buffington wrote: > > src/slave/containerizer/mesos/launch.cpp, line 67 > > <https://reviews.apache.org/r/31444/diff/2/?file=898403#file898403line67> > > > > James brought this up in his review, it looks like you're not plumbing > > through --chroot. > > > > My read on this is that to fix MESOS-1404 the mesos-containerizer > > binary was introduced options like this were passed through using > > launchFlags in MesosContainerizerProcess::_launch > > > > Is that missing here? Nope, you're not missing anything. This patch does not include any code that uses the introduced chroot functionality. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/#review77524 ----------------------------------------------------------- On April 6, 2015, 11:02 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31444/ > ----------------------------------------------------------- > > (Updated April 6, 2015, 11:02 a.m.) > > > Review request for mesos, Chi Zhang, Dominic Hamon, Jay Buffington, Jie Yu, > and James Peach. > > > Bugs: MESOS-2350 > https://issues.apache.org/jira/browse/MESOS-2350 > > > Repository: mesos > > > Description > ------- > > Optionally take a path that the launch helper should chroot to before > exec'ing the executor. It is assumed that the work directory is mounted to > the appropriate location under the chroot. In particular, the path to the > executor must be relative to the chroot. > > Configuration that should be private to the chroot is done during the launch, > e.g. mounting proc and statically configuring basic devices. It is assumed > that other configuration, e.g., preparing the image, mounting in volumes or > persistent resources, is done by the caller. > > Mounts can be made to the chroot (e.g., updating the volumes or persistent > resources) and they will propagate in to the container but mounts made inside > the container will not propagate out to the host. > > It currently assumes that at least {{chroot}}/tmp is writeable and that mount > points {{chroot}}/{tmp,dev,proc,sys} exist in the chroot. > > This is specific to Linux. > > > Diffs > ----- > > src/slave/containerizer/mesos/launch.hpp > 7c8b535746b5ce9add00afef86fdb6faefb5620e > src/slave/containerizer/mesos/launch.cpp > 2f2d60e2011f60ec711d3b29fd2c157e30c83c34 > > Diff: https://reviews.apache.org/r/31444/diff/ > > > Testing > ------- > > Manual testing only so far. This is harder to automate because we need a > self-contained chroot to execute something in... Suggestions welcome. > > > Thanks, > > Ian Downes > >
