----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32845/#review79381 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/32845/#comment128670> Shall we check `framework->pid == from` as we do in `Master::unregisterFramework()`? Also metrcis update `++metrics->messages_unregister_framework;` should be migrated to `removeFramework()`. src/tests/scheduler_tests.cpp <https://reviews.apache.org/r/32845/#comment128672> s/> >/>> here and below. - Alexander Rukletsov On April 3, 2015, 11:50 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32845/ > ----------------------------------------------------------- > > (Updated April 3, 2015, 11:50 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1127 > https://issues.apache.org/jira/browse/MESOS-1127 > > > Repository: mesos > > > Description > ------- > > Renamed UNREGISTER call to UNSUBSCRIBE for consistency. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 783a63ad1cc0edd86605d638046fb959cb6e97e8 > src/examples/low_level_scheduler_libprocess.cpp > 63d34eefb60d13fe2b82905c1cec9b762340e997 > src/examples/low_level_scheduler_pthread.cpp > 6d1f938660c02db75bfcbf7c8de0d941cff1920d > src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b > src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a > src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 > > Diff: https://reviews.apache.org/r/32845/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
